feat(specs): add EIP-7805 spec#1928
feat(specs): add EIP-7805 spec#1928jihoonsong wants to merge 1 commit intoethereum:eips/amsterdam/eip-7805from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-7805 #1928 +/- ##
===========================================================
- Coverage 86.35% 86.21% -0.15%
===========================================================
Files 599 599
Lines 36904 37002 +98
Branches 3771 3798 +27
===========================================================
+ Hits 31868 31900 +32
- Misses 4485 4537 +52
- Partials 551 565 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ereum#1928) * fix(tests): EIP-7825: Pre-Osaka tests consuming more than the tx gas limit cap * fix(tests): EIP-7825: Pre-Osaka BLS tests consuming more than the tx gas limit cap * fix: tox * docs: changelog * chore(tests): make blake2 use dynamic tx limit. * chore(tests): update slow deposit tests. * chore(tests): tstore run until out of gas test. --------- Co-authored-by: spencer-tb <spencer@spencertaylorbrown.uk>
…ereum#1928) * fix(tests): EIP-7825: Pre-Osaka tests consuming more than the tx gas limit cap * fix(tests): EIP-7825: Pre-Osaka BLS tests consuming more than the tx gas limit cap * fix: tox * docs: changelog * chore(tests): make blake2 use dynamic tx limit. * chore(tests): update slow deposit tests. * chore(tests): tstore run until out of gas test. --------- Co-authored-by: spencer-tb <spencer@spencertaylorbrown.uk>
felix314159
changed the base branch from
forks/amsterdam
to
eips/amsterdam/eip-7805
|
Please rebase if you think that this should get merged instead of closed |
|
@felix314159 Let me rebase this by next week. Thanks! |
jihoonsong
force-pushed
the
eips/amsterdam/eip-7805
branch
from
3158215 to
c4bac21
Compare
|
@felix314159 I've rebased this PR. Could you please rebase |
jihoonsong
force-pushed
the
eips/amsterdam/eip-7805
branch
from
c4bac21 to
6088634
Compare
jihoonsong
force-pushed
the
eips/amsterdam/eip-7805
branch
from
6088634 to
b7bed64
Compare
|
we have a workflow that we can trigger to rebase any EIP branch on top of |
felix314159
force-pushed
the
eips/amsterdam/eip-7805
branch
from
b7bed64 to
cf5c369
Compare
|
i rebased the base and target branches on top of latest i can see that github shows a bugged 'commits' and 'files changed' number for me (we had this before). usually this can be fixed by changing the target branch (currently: |
jihoonsong
changed the base branch from
eips/amsterdam/eip-7805
to
devnets/bal/2
jihoonsong
changed the base branch from
devnets/bal/2
to
eips/amsterdam/eip-7805
|
I've done the branch switching trick and now it shows the right commit. Thank you! @felix314159 |
3 participants
What was wrong?
This PR implements EIP-7805 on top of Amsterdam.
How was it fixed?
This PR passes IL transactions as the third parameter to
state_transitionand check if the block satisfies the IL constraints. Note that this check should be done after transaction execution and before withdrawal processing. It is because some withdrawal could make a sender be able to afford their IL transactions, which wasn't possible before.Cute Animal Picture